[Outreachy] New test in t3903-stash.sh : execute git stash without author #1891
Conversation
slavicaDj
changed the title
|
The commit message doesn't explain why this is needed. Are these things (stash without author or HOME set) that you would expect to work anyway, or is it just that any error messages are given at an unhelpful time? I'm guessing that you has a rush action that needed a stash, and you got an error message about failing to have an author email and in the rush don't have time to fix that. Maybe you were just testing stash and it told you you should have set the author variabvle. But it could be more complicated than that because of the HOME issue. |
|
This test is part of enhancement discussed here: https://public-inbox.org/git/[email protected]/T/#u -- I am trying to contribute to said enhancement as Outreachy participant. |
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
from
3d91285 to
4120032
Compare
slavicaDj
changed the title
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
from
4120032 to
fe5305c
Compare
|
Ahh, I though I'd seen something about this on the main Git List. Welcome! Just to clarify, the Git list is for the upstream Git (the master one), which we (the Git for Windows devs, lead by dscho) follow. For our local (to GfW) commits we use the PR process. For the main Git List commits it is plain text patches submitted to the list. Our bot will also do some rudimentary checks such as ensuring that you have 'signed off' the patches (see the Developers Certificate of Origin DCO in the SubmittingPatches file). The commit message should have a short concise one-liner summary that is readable with the log/show commands, and a message that is in the imperative i.e. we tell the computer what to do and why. We also include references to discussions (as you did above). You can always force push an update to this PR, which will run the checks and allow you to see how well it looks, or you can submit the patch directly upstream. You should also mention that the submission is part of the Outreachy programme, as that will put the submission in context, and hopefully prompt helpful responses. |
|
@PhilipOakley FWIW I was in contact (via private Gitter chat) with @slavicaDj and recommended to open this here PR so that I can help prepare this for contribution to the Git mailing list. Feel free to continue to chime in, this is great! |
|
@PhilipOakley thank you for your welcome and constructive feedback! I am working on improving this PR. |
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
from
fe5305c to
8680a7e
Compare
slavicaDj
changed the title
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
6 times, most recently
from
21b046a to
dcc0225
Compare
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
9 times, most recently
from
278cd28 to
910ec8d
Compare
… and user.email Add test to assert that stash fails if user.name and user.email are not configured. In the final commit, test will be updated to expect success. Signed-off-by: Slavica Djukic <[email protected]>
slavicaDj
force-pushed
the
adding_new_test_t3909
branch
2 times, most recently
from
a0ad405 to
7ea3126
Compare
|
For lurkers: this continues on the Git mailing list: https://public-inbox.org/git/[email protected]/#r |
This is test for git stash - it fails when author is not set, and represents known breakage.