mingw: quote argument to 'sh' if it contains brace #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes git-for-windows#1220 Signed-off-by: Kim Gybels <[email protected]>
|
Thank you! Maybe you could provide a commit message that stands on its own, and mark this as Also, did you find any documentation as to what special characters need special handling? I fear that { might not be the only one... |
|
I created the pull request already for discussion, however, I don't know when I'll have time to improve it. |
dscho
added a commit
that referenced
this pull request
Apr 23, 2018
This merges #1637 with an added regression test and a new commit message ready for the next merging rebase (where the faulty commit will be amended). Signed-off-by: Johannes Schindelin <[email protected]>
|
Thanks! I just touched the commit message up a little (to make it easier for me during the next merging rebase), and added a regression test. |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Apr 23, 2018
Aliases that expand to shell commands [can now take arguments containing curly brackets](git-for-windows/git#1637). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 29, 2018
This merges #1637 with an added regression test and a new commit message ready for the next merging rebase (where the faulty commit will be amended). Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 29, 2018
This merges #1637 with an added regression test and a new commit message ready for the next merging rebase (where the faulty commit will be amended). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1220