Fail to access https://github.com/* if portable version is unpacked in a network share.

[omirochn]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.32.0.windows.1
cpu: x86_64
built from commit: 4c204998d0e156d13d81abe1d1963051b1418fc0
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 6.2.9200]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Unpacked a portable package in a network share.
Found no install-options.txt in any of the places 

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

Unpacked into a network share. The same package unpacked in local drive works fine.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

CMD, bash

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

y:\user\tmp\PortableGit-2.32.0-64-bit\bin\git clone https://github.com/git/git

• What did you expect to occur after running these commands?

Success cloning

• What actually happened instead?

Cloning into 'git'...
fatal: unable to access 'https://github.com/git/git/': error setting certificate verify locations: CAfile: /fileserver/share/user/tmp/PortableGit-2.32.0-64-
bit/mingw64/ssl/certs/ca-bundle.crt CApath: none

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

Any repo with https:// URL

[rimrul]

CAfile: /fileserver/share/...

This looks broken.

What does git config http.sslcainfo tell you?

Probably something like \\fileserver\share\…, right?

That probably gets converted to //fileserver/share/... at some point and then further mangled into /fileserver/share/.... Not ideal.

[omirochn]

It tells nothing (empty line):

c:\Temp>y:\user\tmp\PortableGit-2.32.0-64-bit\bin\git config http.sslcainfo

c:\Temp>

[dscho]

I can reproduce (using my WSL setup to emulate a network drive, via \\wsl$\Ubuntu-18.04).

A good workaround seems to be:

y:\user\tmp\PortableGit-2.32.0-64-bit\bin\git config --system http.sslbackend schannel

[dscho]

fatal: unable to access 'https://github.com/git/git/': error setting certificate verify locations: CAfile: /fileserver/share/user/tmp/PortableGit-2.32.0-64-bit/mingw64/ssl/certs/ca-bundle.crt CApath: none

The error message "error setting certificate verify locations" does not actually come from Git, but from cURL: https://github.com/curl/curl/blob/8fa0a298c65548615a86a042b2661d637c532699/lib/vtls/openssl.c#L3087-L3090

However, we do not set the location of the certificate bundle explicitly, it is set implicitly by cURL itself. Or, to be more precise, by our version of it. And the problem seems to be that the first double-slash is turned into a single slash. Which makes me think that the culprit is here: https://github.com/git-for-windows/MINGW-packages/blob/dd2a97114e7f01807dd33fd163156c28e5a3e35a/mingw-w64-curl/0001-Make-cURL-relocatable.patch#L158-L163

I could imagine that the problem would be solved by replacing

  path_p = path;

with

  path_p = path + !!*path; /* skip first character, if any, to handle UNC paths correctly */

[omirochn]

The workaround works!
Thanks!!!

[dscho]

I am testing a fix right now. It looks essentially like this:

diff --git a/mingw-w64-curl/0001-Make-cURL-relocatable.patch b/mingw-w64-curl/0001-Make-cURL-relocatable.patch
index 3c5bfd935..71b82a2e8 100644
--- a/mingw-w64-curl/0001-Make-cURL-relocatable.patch
+++ b/mingw-w64-curl/0001-Make-cURL-relocatable.patch
@@ -26,10 +26,10 @@ Signed-off-by: Johannes Schindelin <[email protected]>
  configure.ac         |   1 +
  lib/Makefile.inc     |   2 +
  lib/curl_config.h.in |   3 +
- lib/pathtools.c      | 556 +++++++++++++++++++++++++++++++++++++++++++
+ lib/pathtools.c      | 562 +++++++++++++++++++++++++++++++++++++++++++
  lib/pathtools.h      |  57 +++++
  lib/url.c            |  26 +-
- 6 files changed, 644 insertions(+), 1 deletion(-)
+ 6 files changed, 650 insertions(+), 1 deletion(-)
  create mode 100644 lib/pathtools.c
  create mode 100644 lib/pathtools.h
 
@@ -81,10 +81,10 @@ index 89a1d195a..8c8305754 100644
  
 diff --git a/lib/pathtools.c b/lib/pathtools.c
 new file mode 100644
-index 000000000..c09458e95
+index 000000000..53d0db00b
 --- /dev/null
 +++ b/lib/pathtools.c
-@@ -0,0 +1,556 @@
+@@ -0,0 +1,562 @@
 +/*
 +      .Some useful path tools.
 +        .ASCII only for now.
@@ -156,7 +156,7 @@ index 000000000..c09458e95
 +    *path_p = '/';
 +  }
 +  /* Replace any '//' with '/' */
-+  path_p = path;
++  path_p = path + !!*path; /* skip first character, if any, to handle UNC paths correctly */
 +  while ((path_p = strstr (path_p, "//")) != NULL)
 +  {
 +    memmove (path_p, path_p + 1, path_size--);
@@ -277,6 +277,12 @@ index 000000000..c09458e95
 +  char * result = path;
 +  char * result_p;
 +  char const ** toks;
++  if (path[0] == '/' && path[1] == '/') {
++    /* preserve UNC path */
++    path++;
++    in_size--;
++    result++;
++  }
 +  sanitise_path(result);
 +  result_p = result;
 +