Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer cannot proceed if Sublime Text is selected, but ST4 is installed, not ST3. #3248

Closed
1 task done
SpacePotatoBear opened this issue Jun 3, 2021 · 2 comments · Fixed by git-for-windows/build-extra#355

Comments

@SpacePotatoBear
Copy link

SpacePotatoBear commented Jun 3, 2021

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

x64

$ git --version --build-options

git version 2.31.1.windows.1
cpu: x86_64
built from commit: c5f0be26a7e3846e3b6268d1c6c4800d838c6bbb
sizeof-long: 4
sizeof-size_t: 8
shell-path: /bin/sh
feature: fsmonitor--daemon

Windows 10

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.19042.1023]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: CustomEditor
Custom Editor Path: "C:\Program Files\Sublime Text\subl.exe" "-w"
Default Branch Option:  
Path Option: Cmd
Plink Path: C:\Program Files\PuTTY\plink.exe
SSH Option: Plink
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Git Pull Behavior Option: Merge
Use Credential Manager: Core
Performance Tweaks FSCache: Enabled
Enable Symlinks: Disabled
Enable Pseudo Console Support: Disabled

  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

No.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

git bash


  • What did you expect to occur after running these commands?

select sublime text, be able to hit next and install

  • What actually happened instead?

next greyed out, had to use a custom editor to work around it.

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?
@rimrul
Copy link
Member

rimrul commented Jun 4, 2021

Yes. The installer expects sublime text sytem installs to be located in "C:\Program Files\Sublime Text 3". The fix should be fairly easy. I'll submit a PR later today.

@SpacePotatoBear
Copy link
Author

Sorry not used to github's ui, Thanks @rimrul

rimrul added a commit to rimrul/build-extra that referenced this issue Jun 4, 2021
Sublime Text has recently been released as version 4. Along with this new
version the install directory has been changed to no longer include the version
number in the directory name. Change the installer to detect newer versions of
Sublime Text and prefer them over version 3.

This fixes git-for-windows/git#3248

Signed-off-by: Matthias Aßhauer <[email protected]>
@dscho dscho added this to the Next release milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants