git archive error "gzip -cn: gzip: command not found" with MinGit package on windows #1970

Rastaban · 2018-12-07T23:31:33Z

[x ] I was not able to find an open or closed issue matching what I'm seeing

git archive does not work if you have the windows MinGit package installed because gzip is missing from the package.

gzip -cn: gzip: command not found

The text was updated successfully, but these errors were encountered:

dscho · 2018-12-07T23:38:22Z

Full example, please.

Rastaban · 2018-12-07T23:43:34Z

Full example:

PS E:\vcpkg\vcpkg> git.exe archive FETCH_HEAD -o e:\vcpkg\vcpkgarchive.tar.gz
gzip -cn: gzip: command not found
PS E:\vcpkg\vcpkg>

dscho · 2018-12-08T07:43:57Z

Okay, it is specific to .tar.gz files. The major problem I have here is that gzip.exe would be needed only for this obscure command, and it would increase the size of the MinZip package (which I don't want). Also, it would encourage people to use gzip from the MinGit package, and that is not what MinGit is about.

Besides, the gzip.exe in Git for Windows' SDK is an MSYS2 one, i.e. it incurs all the problems we have occasionally with the MSYS2 runtime and its DLL base address.

So my current thinking is: If we can somehow implement the bare minimum code in archive-tar.c to perform gzip compression (we already link to zlib, and AFAIU gzip only adds a file header), then we could neatly side-step this issue without bundling gzip.exe.

dscho · 2018-12-08T07:55:09Z

the bare minimum code in archive-tar.c to perform gzip compression

This should help: https://github.com/madler/zlib/blob/master/test/minigzip.c

dscho · 2018-12-09T10:19:32Z

@Rastaban I had a thorough look today, and it seems that the proper solution to this would be to change archive-tar.c to use the git_deflate() facility (with appropriate initialization and cleanup), essentially by changing all call sites of write_or_die() so that they use a git_zstream * (which will have to be handed all the way down in the form of function parameters).

Based on past experience with Git for Windows users, I am not sure whether you fall into the exciting group of contributors who only need minimal guidance and are eager to fix their issue?

If not, you can just go and copy gzip.exe e.g. from http://github.com/git-for-windows/git-sdk-64/tree/master/usr/bin.

Of course, I hope you fall into that exciting group, in which case I would be happy to assist you.

Rastaban · 2018-12-11T19:51:23Z

@dscho, I am unable to commit to it at this time. In order to unblock vcpkg we will switch to one of the larger packages that already has gzip. When I have a block of free time I will take you up on your offer to assist me in making this change (unless someone else gets to it first)

for future reference, where would I find the instructions for building git on windows?

dscho · 2018-12-12T14:02:50Z

where would I find the instructions for building git on windows?

Here: https://github.com/git-for-windows/git/wiki/Building-Git

When I have a block of free time I will take you up on your offer to assist me in making this change

Excellent.

r1walz · 2019-02-08T17:50:32Z

@dscho @Rastaban : If any of you haven't started to work on this issue, can I take this up? This would be my first contribution.

Rastaban · 2019-02-08T18:18:52Z

@r1walz I haven't had a chance to look at it yet, and would be happy to let you take it over.

dscho · 2019-02-08T18:40:14Z

@r1walz go for it! Do you have information to get started?

r1walz · 2019-02-08T18:51:59Z

@dscho : yes, I'd love to receive some extra information

PhilipOakley · 2019-02-08T20:00:06Z

Hi @r1walz - Is there any specific information that is currently missing in this issue (#1970) thread for you, at least to get started with a trial build of the current release, just to 'pipe clean' the process?

If any of the wiki/Building-Git steps fail to work for you then do please do tell us so we can improve them.

Philip

dscho · 2019-02-12T10:28:01Z

@r1walz did you manage to compile (and use) minigzip.c (mentioned in #1970) yet?

r1walz · 2019-02-12T16:47:56Z

@dscho yes, I was able to compile and run minigzip.c, but are we not going according to this plan?

dscho · 2019-02-13T15:37:19Z

For lurkers: we talked more on IRC.

dscho · 2019-02-20T16:00:42Z

@r1walz this was quite the pleasant contribution, thank you so much!

MinGit for Windows comes without `gzip` bundled inside, git-archive uses `gzip -cn` to compress tar files but for this to work, gzip needs to be present on the host system, which sometimes is not the case In the next commit, we will change the gzip compression so that we no longer spawn `gzip` but let zlib perform the compression in the same process In preparation for this, we consolidate all the block writes into a single function Closes: git-for-windows#1970 Signed-off-by: Rohit Ashiwal <[email protected]>

MinGit for Windows comes without `gzip` bundled inside, git-archive uses `gzip -cn` to compress tar files but for this to work, gzip needs to be present on the host system. In the next commit, we will change the gzip compression so that we no longer spawn `gzip` but let zlib perform the compression in the same process instead. In preparation for this, we consolidate all the block writes into a single function. This closes git-for-windows#1970 Signed-off-by: Rohit Ashiwal <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>

MinGit for Windows comes without `gzip` bundled inside, git-archive uses `gzip -cn` to compress tar files but for this to work, gzip needs to be present on the host system. In the next commit, we will change the gzip compression so that we no longer spawn `gzip` but let zlib perform the compression in the same process instead. In preparation for this, we consolidate all the block writes into a single function. This closes #1970 Signed-off-by: Rohit Ashiwal <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>