installer: only use SW_HIDE on custom editors that use a wrapper script #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently assuming that directly called editors ignore our request to hide their initial window, but some editors honor that request. This causes the installer to get stuck waiting for user input in a hidden window. This fixes git-for-windows/git#2684. Signed-off-by: Matthias Aßhauer <[email protected]>
dscho
reviewed
Sep 7, 2020
| @@ -1494,7 +1496,13 @@ begin | |||
| InputText:='Please modify this text, e.g. delete it, then save it and exit the editor.' | |||
| SaveStringToFile(TmpFile,InputText,False); | |||
|
|
|||
| if not ShellExec('',CustomEditorPath,CustomEditorOptions+' "'+TmpFile+'"','',SW_HIDE,ewWaitUntilTerminated,Res) then begin | |||
| CustomEditorExt:=ExtractFileExt(CustomEditorPath); | |||
| if (CompareText(CustomEditorExt,'.bat')=0) or (CompareText(CustomEditorExt,'.cmd')=0) then | |||
There was a problem hiding this comment.
Do we need to do this for .ps1 scripts, too?
There was a problem hiding this comment.
No. Powershell launches them fine even with SW_HIDE. They aren't on PATHEXT by default, though and their default associaton is to open them with notepad.
dscho
added a commit
that referenced
this pull request
Sep 29, 2020
It is [now possible](#303) to use `wordpad.exe` as Git's editor of choice. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently assuming that directly called editors ignore our request
to hide their initial window, but some editors honor that request.
This causes the installer to get stuck waiting for user input in a
hidden window.
This fixes git-for-windows/git#2684.