avoid Github API rate limit #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
requested changes
Mar 13, 2019
The Github API has a per-user rate limit. For anonymous users, which we are, the limit counts per IP address. For large organizations this can be an issue. Instead, make the latest version check against gitforwindows.org. We still make calls to the Github API when we decide that we should download a new release. But this happens only once per user and Git release. Signed-off-by: Clemens Buchacher <[email protected]>
drizzd
force-pushed
the
avoid-github-rate-limit
branch
from
8c37b1e to
4fd27ef
Compare
|
Thanks! |
dscho
added a commit
that referenced
this pull request
Mar 13, 2019
Git for Windows' updater [no longer runs into GitHub API rate limits](#242) (this used to be quite common in enterprise scenarios, where many users would share one IP as far as GitHub is concerned). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github API has a per-user rate limit. For anonymous users, which we
are, the limit counts per IP address. For large organizations this can
be an issue. Instead, make the latest version check against
gitforwindows.org.
We still make calls to the Github API when we decide that we should
download a new release. But this happens only once per user and Git
release.
Signed-off-by: Clemens Buchacher [email protected]
See also git-for-windows/git#1813.