notepad: don't break comments in COMMIT_EDITMSG #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping lines with fmt could cause comments in COMMIT_EDITMSG to turn into a comment line and one or more non-comment lines. Wrapping just the comments with the -p option before wrapping the other lines prevents this from happening. This fixes git-for-windows/git#1967 Signed-off-by: Matthias Aßhauer <[email protected]>
rimrul
changed the title
|
I've tested it and it seems to work as intended. |
|
Very neat, thanks! |
dscho
added a commit
that referenced
this pull request
Dec 6, 2018
A bug in the `notepad` support in conjunction with line wrapping [was fixed](#218). Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping lines with fmt could cause comments in COMMIT_EDITMSG to turn into a
comment line and one or more non-comment lines. Wrapping just the comments with
the -p option before wrapping the other lines prevents this from happening.
This fixes git-for-windows/git#1967
I've marked this as "don't merge yet", because I haven't tested it yet. Will update this PR soon.