Feat/update scheduler v2 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roger Meier <[email protected]>
dscho
reviewed
Sep 8, 2017
git-extra/git-update
Outdated
| @@ -5,6 +5,13 @@ | |||
| # when confirmation to do so is given. | |||
|
|
|||
| git_update () { | |||
| proxy=$(git config --get http.proxy) | |||
| if test "$proxy" != "" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dscho
reviewed
Sep 8, 2017
git-extra/git-update
Outdated
| proxy=$(git config --get http.proxy) | ||
| if test "$proxy" != "" | ||
| then | ||
| export https_proxy="http://$proxy" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dscho
reviewed
Sep 8, 2017
|
|
||
| [UninstallRun] | ||
| Filename: "schtasks"; \ | ||
| Parameters: "/Delete /F /TN ""Git for Windows Updater"""; \ |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
dscho
force-pushed
the
feat/update-scheduler-v2
branch
from
2ad7207 to
debc320
Compare
Signed-off-by: Roger Meier <[email protected]> Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
feat/update-scheduler-v2
branch
from
debc320 to
df85f0c
Compare
|
Thank you! I actually just realized that I can force-push updates to your branch, so i just went ahead and made the modifications myself. While at it, I also redirected a couple more messages to stderr. |
dscho
added a commit
that referenced
this pull request
Sep 8, 2017
The Git installer now offers [an option to keep Git up-to-date](#155). Signed-off-by: Johannes Schindelin <[email protected]>
|
@dscho Thank so much! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #153 and uses git
http.proxysettings as suggested by @dscho