git: fix asciidoctor invocation #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating the `config.mak` to tell `make` to use asciidoctor `instead` of `asciidoc`, lets make sure that we only quote the parts that needs it. Quoting the full `ASCIIDOCTOR_CONF` variable is leading to a wrong invocation of the `asciidoctor` command because then the different asciidoctor options `-I` and `-r` are not being recognized. This fixes git-for-windows/git#404 Signed-off-by: 마누엘 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the
config.makto tellmaketo use asciidoctorinsteadof
asciidoc, lets make sure that we only quote the parts that needs it.Quoting the full
ASCIIDOCTOR_CONFvariable is leading to a wronginvocation of the
asciidoctorcommand because then the differentasciidoctor options
-Iand-rare not being recognized.This fixes git-for-windows/git#404