Add support for using WSL Git for configuration #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a CreateProcess method on the IEnvironment component. This will serve as a place to consolidate Process object creation that currently exists in multiple places.
mjcheetham
added
enhancement
Use the new CreateProcess method on the IEnvironment component in the GitProcess class.
Add support for calling back to the Git executable in a Windows Subsystem for Linux (WSL).
mjcheetham
requested review from
vdye,
derrickstolee,
jeffhostetler,
ldennington and
vtbassmatt
| Assert.True(process.StartInfo.RedirectStandardError); | ||
| Assert.False(process.StartInfo.UseShellExecute); | ||
| } | ||
|
|
There was a problem hiding this comment.
This might be overkill, but we might also test that git --exec-path returns the expected value.
There was a problem hiding this comment.
We cannot do this easily as we need to be invoked from a WSL distro, with specific environment variables set etc. These tests don't actually start any processes, just check that the Process object is constructed correctly, and is ready to be .Start()ed.
|
|
||
| To do this, simply follow the [GCM installation instructions for Linux](../README.md#linux-install-instructions). | ||
|
|
||
| **Note:** In this scenario, because GCM is running as a Linux application |
There was a problem hiding this comment.
Does this also mean that GCM won't have a GUI available?
There was a problem hiding this comment.
The answer here is "it depends". We have GUI options for GCM+Linux. If the user has "gWSL" set up, then Linux GUI apps also work and appear as windows on the Windows host.
jeffhostetler
approved these changes
Sep 21, 2021
vtbassmatt
approved these changes
Sep 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables GCM to understand values of
GIT_EXEC_PATHthat point to a Windows Subsystem for Linux (WSL) path, for example\\wsl$\ubuntu\usr\libexec\git-core.This can use useful for scenarios where the user does not want to install Git for Windows or use it's configuration files, but rather use the WSL Git's view of the world.
Also add a piece of documentation that outlines how to correctly configure GCM and WSL.