Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the /usr/local/bin directory exists on install #257

Merged
merged 2 commits into from
Jan 4, 2021

Conversation

mjcheetham
Copy link
Collaborator

Ensure the /usr/local/bin directory exists on macOS installations before we create the symlink for GCM Core. The directory does not exist on freshly installed Macs.

Fixes #256

Ensure the /usr/local/bin directory exists on macOS installations before
we create the symlink for GCM Core. The directory does not exist on
freshly installed Macs.
@mjcheetham mjcheetham added bug A bug in Git Credential Manager installation Specific to installation and uninstallation platform:osx Specific to the macOS platform labels Jan 4, 2021
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks obviously correct to me.

My only (slight) concern is that Homebrew might expect a certain set of permissions of that directory, but it probably adjusts them when being installed, anyway.

Add a local nuget.config file to force the package source used for NuGet
packages to be only the nuget.org public feed.

There have been problems with some CI agents that don't have a
global/default nuget.org package source.
@mjcheetham
Copy link
Collaborator Author

My only (slight) concern is that Homebrew might expect a certain set of permissions of that directory, but it probably adjusts them when being installed, anyway.

This was my thought too.. Also, I've just added a nuget.config file to explicitly set nuget.org as the package source to get around these build issues.

@mjcheetham mjcheetham merged commit c7a7719 into git-ecosystem:master Jan 4, 2021
@mjcheetham mjcheetham deleted the fixosxinstall branch January 4, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in Git Credential Manager installation Specific to installation and uninstallation platform:osx Specific to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install failed when /usr/local/bin directory does not exist in macOS
3 participants