Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of box drawing characters in warning output #243

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Remove use of box drawing characters in warning output #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/shared/Microsoft.Git.CredentialManager/HttpClientFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ public HttpClient CreateClient()
if (!_settings.IsCertificateVerificationEnabled)
{
_trace.WriteLine("TLS certificate verification has been disabled.");
_streams.Error.WriteLine("warning: ┌──────────────── SECURITY WARNING ───────────────┐");
_streams.Error.WriteLine("warning: │ TLS certificate verification has been disabled! │");
_streams.Error.WriteLine("warning: └─────────────────────────────────────────────────┘");
_streams.Error.WriteLine("warning: ----------------- SECURITY WARNING ----------------");
_streams.Error.WriteLine("warning: | TLS certificate verification has been disabled! |");
_streams.Error.WriteLine("warning: ---------------------------------------------------");
_streams.Error.WriteLine($"warning: HTTPS connections may not be secure. See {Constants.HelpUrls.GcmTlsVerification} for more information.");

#if NETFRAMEWORK
Expand Down
24 changes: 12 additions & 12 deletions src/shared/Microsoft.Git.CredentialManager/Settings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,18 +277,18 @@ public bool IsInteractionAllowed
* We've slightly changed the behaviour of this setting in GCM Core to essentially
* remove the 'always' option. The table below outlines the changes:
*
* ┌──────────┬───────────────────────────┬────────────────────┐
* │ Value(s) │ Old meaning │ New meaning │
* ┝━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━━━━━━━━┿━━━━━━━━━━━━━━━━━━━━┥
* │ auto │ Prompt if required │ [unchanged] │
* ├──────────┼───────────────────────────┼────────────────────┤
* │ never │ Never prompt ─ fail if │ [unchanged] │
* │ false │ interaction is required │ │
* ├──────────┼───────────────────────────┼────────────────────┤
* │ always │ Always prompt ─ don't use │ Prompt if required │
* │ force │ cached credentials │ │
* │ true │ │ │
* └──────────┴───────────────────────────┴────────────────────┘
* -------------------------------------------------------------
* | Value(s) | Old meaning | New meaning |
* |-----------------------------------------------------------|
* | auto | Prompt if required | [unchanged] |
* |-----------------------------------------------------------|
* | never | Never prompt ─ fail if | [unchanged] |
* | false | interaction is required | |
* |-----------------------------------------------------------|
* | always | Always prompt ─ don't use | Prompt if required |
* | force | cached credentials | |
* | true | | |
* -------------------------------------------------------------
*/
if (StringComparer.OrdinalIgnoreCase.Equals("never", value))
{
Expand Down