Add explicit PAT authentication mode for the GitHub Provider #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an authentication mode to the GitHub provider whereby a Personal Access Token can be returned directly, as generated by a user manually. Update the terminal-based UI menu to support the new PAT mode.
Update the WPF-based Windows GUI for GitHub authentication prompts to support the third authentication mode "PAT". Also make some changes to how the dialog window is sized to scale with the size of the content (mins and maxes included), which may now vary in the extreme from all three auth options, to just one.
mjcheetham
added
enhancement
jeffhostetler
approved these changes
Nov 25, 2020
Correctly quote and escape arguments passed to authentication helpers via the process arguments.
|
Your new quoting scheme looks good. Thanks. |
This was referenced Nov 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an authentication mode to the GitHub provider whereby a Personal Access Token can be returned directly, as generated by a user manually. This mode is always supported on both github.com and GHES, as it should always be possible to create a PAT manually for whatever access is required.
This functionality sort-of already exists, but requires a few things:
GCM_GITHUB_AUTHMODES=basic)We update the WPF-based Windows GUI for GitHub authentication prompts to support the third authentication mode "PAT". There are also make some changes to how the dialog window is sized to scale with the size of the content (mins and maxes included), which may now vary in the extreme from all three auth options, to just one.
github.com with OAuth and PAT options
GHES with basic and PAT options
GHES with the PAT option only
A scenario where all options are presented. Currently not possible due to GHES not supporting GCM Core via OAuth, and github.com no longer supporting basic auth - showing to prove the case should this happen such as by user override, or in future development.
Fixes #222