Add several metrics in compute #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbousquet
reviewed
Feb 11, 2020
| public field: string = this.getConfigValue('field'); | ||
| /** Field on which the metric will be computed*/ | ||
| public metric: string = this.getConfigValue('metric'); | ||
| /** Array of which the metric will be computed*/ |
There was a problem hiding this comment.
which metrics instead of which the metric
mbarbet
force-pushed
the
feature/enhanceCompute
branch
from
3617602 to
f5aee5d
Compare
MohamedHamouGisaia
approved these changes
Feb 11, 2020
mbarbet
force-pushed
the
feature/enhanceCompute
branch
from
f5aee5d to
56db2bc
Compare
MohamedHamouGisaia
changed the title
mbarbet
force-pushed
the
feature/enhanceCompute
branch
from
56db2bc to
7c8f266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #287