Use search after/before instead of from and size #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebbousquet
approved these changes
Jul 9, 2019
MohamedHamouGisaia
force-pushed
the
feature/searchafter_list
branch
2 times, most recently
from
f5e0ede to
57a5be6
Compare
mbarbet
requested changes
Jul 11, 2019
There was a problem hiding this comment.
After some test, the geosort with id sort does not work.
Fix it before merge
Don't use values from map list for after param : this value could be different from the source
Edit
The map includes _previousAfter & _nextAfter keys to insure the update with the source
mbarbet
force-pushed
the
feature/searchafter_list
branch
from
d55fe20 to
c361a69
Compare
mbarbet
reviewed
Jul 18, 2019
MohamedHamouGisaia
force-pushed
the
feature/searchafter_list
branch
from
c361a69 to
44fa277
Compare
sebbousquet
approved these changes
Jul 25, 2019
mbarbet
approved these changes
Jul 25, 2019
MohamedHamouGisaia
force-pushed
the
feature/searchafter_list
branch
from
f89ce14 to
b746ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #176
Fix #191
Fix #192