Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAP] Bug in extents : rawExtent is for test & wrapExtent is for load #312

Closed
MohamedHamouGisaia opened this issue May 23, 2020 · 0 comments · Fixed by #317
Closed

[MAP] Bug in extents : rawExtent is for test & wrapExtent is for load #312

MohamedHamouGisaia opened this issue May 23, 2020 · 0 comments · Fixed by #317
Assignees
Labels
Milestone

Comments

@MohamedHamouGisaia
Copy link
Member

When we apply the count on the current map extent, we use two variables :

  • rawExtent: provided by newMove.rawExtendForLoad
  • wrapExtent: provided by newMove.extendForLoad

Those two variables are used to calculate the correct count at longitude 180.

But, actually rawExtendForLoad provided by the MapComponent is in reality a test extent and should be renamed rawExtendForTest. Therefore, wrapExtent is a load extent and rawExtent is test extent.

Those two extents have different aims and should not be compared at 180° comparing ==> wrapExtent should be provided by newMove.extendForTest instead of newMove.extendForLoad

@MohamedHamouGisaia MohamedHamouGisaia added this to the 13.0.0 milestone May 23, 2020
@MohamedHamouGisaia MohamedHamouGisaia self-assigned this May 23, 2020
MohamedHamouGisaia added a commit that referenced this issue May 25, 2020
MohamedHamouGisaia added a commit that referenced this issue May 25, 2020
MohamedHamouGisaia added a commit that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant