-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change json lib to jsoniter #990
Conversation
A high-performance 100% compatible drop-in replacement of "encoding/json" https://github.com/json-iterator/go Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy test failed:
Both of them fail because |
Signed-off-by: Bo-Yi Wu <[email protected]>
@javierprovecho I already fixed it this commit 08338ef |
Signed-off-by: Bo-Yi Wu <[email protected]>
@appleboy it will keep failing, the tests here are trivial, |
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 16 16
Lines 1412 1412
=======================================
Hits 1363 1363
Misses 39 39
Partials 10 10
Continue to review full report at Codecov.
|
@javierprovecho Yes. maybe we need open the issue to https://github.com/json-iterator/go |
Signed-off-by: Bo-Yi Wu <[email protected]>
jsoniter also does not seem to work on Google App Engine (use of unsafe). One option may be to enable/disable this via build tags. |
A high-performance 100% compatible drop-in replacement of "encoding/json"
https://github.com/json-iterator/go
cc @javierprovecho @tboerger
Signed-off-by: Bo-Yi Wu [email protected]