Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Go versions and dependencies for improved compatibility #4187

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Mar 18, 2025

  • Update Go versions in workflow file to 1.23 and 1.24
  • Enhance test tags in workflow with specific linker flags
  • Remove the conditional formatting step for Go 1.22.x in workflow
  • Remove goimports settings from .golangci.yml
  • Update go.mod to use Go 1.23.0
  • Upgrade github.com/bytedance/sonic from v1.11.6 to v1.13.1
  • Update indirect dependencies sonic/loader to v0.2.4 and base64x to v0.1.5 in go.mod

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.99%. Comparing base (3dc1cd6) to head (fdcea74).
Report is 93 commits behind head on master.

Files with missing lines Patch % Lines
debug.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4187      +/-   ##
==========================================
- Coverage   99.21%   98.99%   -0.22%     
==========================================
  Files          42       44       +2     
  Lines        3182     3395     +213     
==========================================
+ Hits         3157     3361     +204     
- Misses         17       24       +7     
- Partials        8       10       +2     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags "sonic avx" 98.99% <0.00%> (?)
-tags go_json 98.99% <0.00%> (?)
-tags nomsgpack 98.98% <0.00%> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.23 98.99% <0.00%> (?)
go-1.24 98.99% <0.00%> (?)
macos-latest 98.99% <0.00%> (-0.22%) ⬇️
ubuntu-latest 98.99% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Update Go versions in workflow file to `1.23` and `1.24`
- Enhance test tags in workflow with specific linker flags
- Remove the conditional formatting step for Go `1.22.x` in workflow
- Remove `goimports` settings from `.golangci.yml`
- Update `go.mod` to use Go `1.23.0`
- Upgrade `github.com/bytedance/sonic` from `v1.11.6` to `v1.13.1`
- Update indirect dependencies `sonic/loader` to `v0.2.4` and `base64x` to `v0.1.5` in `go.mod`

Signed-off-by: appleboy <[email protected]>
@appleboy appleboy changed the title ci: update CI configurations and drop support for outdated tools chore: update Go versions and dependencies for improved compatibility Mar 18, 2025
@appleboy appleboy requested a review from thinkerou March 18, 2025 15:52
@appleboy
Copy link
Member Author

@thinkerou Please help to review.

@thinkerou
Copy link
Member

@appleboy readme and debug.go should also be updated

- Update Go version requirement from 1.22 to 1.23 in README.md
- Remove superfluous `$` from example command in README.md
- Update warning message to reflect new Go version requirement in debug.go
- Update test assertion to reflect new Go version requirement in debug_test.go

Signed-off-by: appleboy <[email protected]>
@appleboy
Copy link
Member Author

@thinkerou See fdcea74 (#4187)

@thinkerou thinkerou merged commit 90cf460 into gin-gonic:master Mar 20, 2025
23 of 25 checks passed
@appleboy appleboy deleted the ci branch March 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants