Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add go version judge when print debug warning log #1572

Merged
merged 3 commits into from
Sep 26, 2018
Merged

feat: add go version judge when print debug warning log #1572

merged 3 commits into from
Sep 26, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Sep 26, 2018

ref: #1381

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1572      +/-   ##
==========================================
+ Coverage   99.06%   99.06%   +<.01%     
==========================================
  Files          39       39              
  Lines        1922     1929       +7     
==========================================
+ Hits         1904     1911       +7     
  Misses         14       14              
  Partials        4        4
Impacted Files Coverage Δ
debug.go 95.74% <100%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd599fc...6b6d8c2. Read the comment docs.

@thinkerou thinkerou merged commit 834a2ec into gin-gonic:master Sep 26, 2018
@thinkerou thinkerou deleted the w branch October 20, 2018 00:03
justinfx pushed a commit to justinfx/gin that referenced this pull request Nov 3, 2018
* feat: add go version judge when print debug warning log

* remove invalid statement

* use one const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants