Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration of the scheduler and orchestrator packages #65

Merged
merged 18 commits into from
Feb 7, 2025
Merged

Migration of the scheduler and orchestrator packages #65

merged 18 commits into from
Feb 7, 2025

Conversation

augustocristian
Copy link
Contributor

This PR is related and closes #58 contains the following changes:

  • The scheduler and orchestrator packages, with the necessary code to generate the TJobs and Execution plans
  • The necessary objects in the model folder
  • The unitary test cases of both components
  • The integration test of the whole orchestration generator.

@augustocristian augustocristian linked an issue Dec 13, 2024 that may be closed by this pull request
Start migration of retorch-orchestration tool #58
Closed
@augustocristian augustocristian force-pushed the ft_migrateschedulerorchestrator branch from 1aba782 to 937bb4b Compare December 13, 2024 18:07
@augustocristian
Copy link
Contributor Author

augustocristian commented Dec 13, 2024 •
edited
Loading

As you requested @javiertuya #59 (review), I've migrated the module that generates the Jenkinsfiles (nothing related to the UsageProfile or the Cost estimation).
I've refactored a lot and the current version is far away to the ones that are in GitLab, I've removed a lot of duplications and dummy methods not used. Looks like that there are a lot of new files, but most of them are base files to generate the jenkinsfile and desired outputs for the test cases.

javiertuya
javiertuya requested changes Dec 15, 2024
View reviewed changes
@augustocristian
Fixing:
22c09da 
- All the scripts with comments and added some description also to the .env files
- Removed unnecesary comments in pom.xml
- Removed all the references to "tool" or "package"
@augustocristian
Fixing:
f70a875 
- All the scripts with comments and added some description also to the .env files
- Removed unnecesary comments in pom.xml
- Removed all the references to "tool" or "package"
@augustocristian
Changes:
c616dad 
- Adding the I to the interface name
- Removed the enum and created a method that generates dinamically an alphabetical identifier.
@augustocristian
Changes:
ea77160 
- Added Jenkinsfile generator to the main
- Aligned the prior methods
- Removed capital
@augustocristian
Changes:
6136a37 
- Added Jenkinsfile generator to the main
- Aligned the prior methods
- Removed capital
javiertuya
javiertuya requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@javiertuya javiertuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review done, but problems generating the jenkinsfile according to the documentation.

@augustocristian
Changes:
0b7d4f2 
- Adding the validation to the tjob.env files
- Adding some support methods to validate the files
- Changed the delimitation character (from [IMG:] to ;
@augustocristian
Changes:
f4af7c3 
- Some minor typos in the ExecutionPlan.java
- Adjusting tjob and orchestration outputs
@augustocristian
Changes:
324b435 
- Fixing the full qualified class name
- Reviewed that all paths to the files matchs.
@augustocristian augustocristian mentioned this pull request Jan 2, 2025
Open
javiertuya
javiertuya requested changes Jan 24, 2025
View reviewed changes
javiertuya
javiertuya requested changes Jan 30, 2025
View reviewed changes
javiertuya
javiertuya requested changes Feb 6, 2025
View reviewed changes
@javiertuya javiertuya merged commit 8c48abb into main Feb 7, 2025
7 checks passed
@javiertuya javiertuya deleted the ft_migrateschedulerorchestrator branch February 7, 2025 08:16
@javiertuya javiertuya mentioned this pull request Feb 7, 2025
Open
@augustocristian augustocristian mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiertuya javiertuya javiertuya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start migration of retorch-orchestration tool
2 participants
@augustocristian @javiertuya