Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quota percentage at row, cardinality name #9

Merged
merged 4 commits into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "qryn-view",
"version": "0.28.0",
"version": "0.28.1",
"description": "Data Explorer UI for qryn",
"repository": {
"type": "git",
Expand Down
12 changes: 9 additions & 3 deletions packages/main/plugins/Cardinality/Configurator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const Configurator: React.FC<ConfiguratorProps> = ({
useCardinalityStore();
const handleReset = () => {
reset();
localStorage.setItem("labelValuePairs","")
localStorage.setItem("labelValuePairs", "");
handleCardinalityRequest({
match: "",
focusLabel: "",
Expand Down Expand Up @@ -139,11 +139,17 @@ const Configurator: React.FC<ConfiguratorProps> = ({
totalSeries.diff === 0
? "none"
: totalSeries.diff > 0
? "up"
: "down"
? "up"
: "down"
}
text={"diff"}
/>
<Totals
theme={theme}
type={"prev"}
value={totalSeries.quota}
text={"quota"}
/>
</div>

<div className="buttons-group">
Expand Down
19 changes: 15 additions & 4 deletions packages/main/plugins/Cardinality/SeriesRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export type SeriesRowProps = {

export type QuotaCellProps = {
quota: number;
cardinality: number;
isQuotaWarning: boolean;
};

Expand All @@ -52,13 +53,17 @@ export const QuotaSquare = (isWarning: boolean) => css`
}
`;

export const QuotaCell = ({ quota, isQuotaWarning }: QuotaCellProps) => {
export const QuotaCell = ({
quota,
cardinality,
isQuotaWarning,
}: QuotaCellProps) => {
return (
<div className={cx(QuotaSquare(isQuotaWarning))}>
<div className={"square"}></div>
<div className={"info-icon"}>
<Tooltip
title={`cardinality quota ${
title={`cardinality over quota percentage ${
isQuotaWarning ? "warning" : "(no warning)"
}`}
>
Expand All @@ -71,7 +76,9 @@ export const QuotaCell = ({ quota, isQuotaWarning }: QuotaCellProps) => {
/>
</Tooltip>
</div>
<p className="quota-num">{quota}</p>
<p className="quota-num">
{calcQuotaOverCardinality(cardinality, quota)}%
</p>
</div>
);
};
Expand Down Expand Up @@ -113,7 +120,11 @@ const SeriesRow: React.FC<SeriesRowProps> = ({

{hasShare && <ShareCell share={share} />}
<div className="cell">
<QuotaCell quota={quota} isQuotaWarning={quotaWarning} />
<QuotaCell
quota={quota}
cardinality={value}
isQuotaWarning={quotaWarning}
/>
</div>
<div className="cell">
<div
Expand Down
6 changes: 5 additions & 1 deletion packages/main/plugins/Cardinality/Totals.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type TotalsProps = {
theme: any;
value: number | string;
trend?: "up" | "down" | "none";
text: "total" | "percent" | "previous" | "diff";
text: "total" | "percent" | "previous" | "diff" | "quota";
type?: "amount" | "prev" | "diff";
};

Expand Down Expand Up @@ -75,6 +75,10 @@ const TOTALS_VALUES = {
text: "Diff from previous",
value: (val: string | number | null | undefined) => `${val ?? 0 }`,
},
quota: {
text: "Quota",
value : (val: string | number ) => `${val}`
}
};
export const Totals: React.FC<TotalsProps> = ({
theme,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export const useCardinalityData = (historyManager?, setHistoryItem?) => {
amount: result.totalSeries,
prev: result.totalSeriesPrev,
diff: result.totalSeries - result.totalSeriesPrev,
quota: result?.quota || 0
});

setData({
Expand Down
7 changes: 4 additions & 3 deletions packages/main/plugins/Cardinality/helpers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,12 @@ export const getSeriesProps = (series: any, focusLabel?: string) => {
};

export function calcQuotaOverCardinality(cardinality: number, quota: number) {
return (cardinality / quota) * 100 - 5;
if (quota === 0) return 0;

return (cardinality * 100) / quota;
}

export function isQuotaWarning(quotaOverCardinality: number) {

if(quotaOverCardinality === Infinity) return false
if (quotaOverCardinality === 0) return false;
return quotaOverCardinality > 60;
}
2 changes: 1 addition & 1 deletion packages/main/plugins/Cardinality/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Cardinality } from "./Cardinality";


export const CardinalViewPlugin: Plugin = {
name: "Cardinal View",
name: "Cardinality View",
section: "Query Item",
id: nanoid(),
Component: Cardinality,
Expand Down
4 changes: 3 additions & 1 deletion packages/main/plugins/Cardinality/store/CardinalityStore.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ type CardinalityTotal = {
amount: number;
prev: number;
diff: number;
quota: number;
};

type TimeRange = {
Expand Down Expand Up @@ -57,7 +58,7 @@ type CardinalityState = {
};

const initialData = {
total: { amount: 0, prev: 0, diff: 0 },
total: { amount: 0, prev: 0, diff: 0, quota: 0 },

date: dayjs().format(DATE_FORMAT),

Expand Down Expand Up @@ -87,6 +88,7 @@ const useCardinalityStore = create<CardinalityState>((set) => ({

setIsUpdating: (isUpdating: boolean) => set(() => ({ isUpdating })),
setTotal: (t: CardinalityTotal) => set(() => ({ total: t })),

setTimeSeriesSelector: (text: string) =>
set(() => ({ timeSeriesSelector: text })),
setTimeRange: (timeRange: TimeRange) => set(() => ({ timeRange })),
Expand Down
31 changes: 25 additions & 6 deletions packages/main/plugins/PluginManagerFactory.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export function LocalPluginsManagement() {
if (!plugins[location]) {
plugins[location] = [];
}

if (!plugins[location]?.some((s: any) => s.name === plugin.name)) {
plugins[location].push(plugin);
localStorage.setItem("plugins", JSON.stringify(plugins));
Expand Down Expand Up @@ -171,10 +170,30 @@ export function PluginManagerFactory(locations: ILocations) {
const lp = LocalPluginsManagement();
let localPlugins = lp.getAll();

// const dispatch: any = store.dispatch
function registerPlugin(plugin: any, totalPlugins: Plugin[]) {
// check for registered plugins vs locally stored
if (totalPlugins?.length > 0) {
for (const existingPlugin of totalPlugins) {
const section = existingPlugin.section;

if (localPlugins[section]) {
const totalPluginsFound = totalPlugins
.filter((pl) => pl.section === section)
.map(({ name }) => name);

const filtered = localPlugins[section]?.filter(
(p) => !totalPluginsFound.includes(p.name)
);

if (filtered?.length > 0) {
filtered.forEach(({ section, name }) => {
lp.removePlugin(section, name);
});
}
}
}
}

// add plugin to a specific location
function registerPlugin(plugin: any) {
if (!plugins[plugin.section]) {
plugins[plugin.section] = [];
}
Expand All @@ -195,7 +214,7 @@ export function PluginManagerFactory(locations: ILocations) {
function registerPluginGlobally(plugin: any) {
for (let location in locations) {
if (location !== "Main") {
registerPlugin(plugin);
registerPlugin(plugin, plugins);
}
}
}
Expand Down Expand Up @@ -264,7 +283,7 @@ export const PluginManager = PluginManagerFactory(locations);
export function initPlugins(plugins: Plugin[]) {
plugins.forEach((plugin: any) => {
if (plugin.visible) {
PluginManager.registerPlugin(plugin);
PluginManager.registerPlugin(plugin, plugins);
}
});
}
6 changes: 3 additions & 3 deletions packages/main/views/Main/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export async function checkLocalAPI(
setResponseType(ResponseEnum.GO);
LocalPluginsManagement().togglePluginVisibility(
"Query Item",
"Cardinal View",
"Cardinality View",
true
);

Expand All @@ -186,12 +186,12 @@ export async function checkLocalAPI(
setResponseType(ResponseEnum.NODE);
LocalPluginsManagement().togglePluginVisibility(
"Query Item",
"Cardinal View",
"Cardinality View",
false
);
LocalPluginsManagement().togglePlugin(
"Query Item",
"Cardinal View",
"Cardinality View",
false
)
isReady = true;
Expand Down
Loading