Narrow egress rule down targeting DNS service only #186
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matias Charriere <[email protected]>
ubergesundheit
previously approved these changes
Feb 17, 2025
fhielpos
previously approved these changes
Feb 17, 2025
fhielpos
dismissed stale reviews from ubergesundheit and themself
via
f55b09c
Signed-off-by: Matias Charriere <[email protected]>
fhielpos
approved these changes
Feb 17, 2025
|
Feel free to merge it if you are done Mati, I can release it later today 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matias Charriere [email protected]
Having both egress and ingress targeting entire cluster is causing issues to schedule the trivy pod on big clusters. This is because the policy is big enough to fill the BPF map up.
In the egress case, I understand that you are only meant to target the DNS service; so narrowing it down to only the DNS service pods labels makes sense to me.
On the ingress side, I'm not sure what is the real traffic that comes in.
Checklist
values.yamlandvalues.schema.jsonare valid.Important: After this PR is tested and approved, ensure you "Squash and Merge" unless you are updating a subtree. The release automation in use on this repository relies on squashing, but git subtrees will be lost if squashed. This repo allows both, so you may need to change the merge type when merging.