Add proxy port to CNP if needed #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 14, 2024 16:15
| } | ||
| proxyPort := proxyURL.Port() | ||
| if proxyPort == "" { | ||
| proxyPort = "80" |
There was a problem hiding this comment.
Well this is nasty but if it works
There was a problem hiding this comment.
Do you have a suggestion to avoid that ?
There was a problem hiding this comment.
Well, the think is if it is https, it should be 443 and not 80 but no the nasty part was more about the nested proxy things above btw
There was a problem hiding this comment.
I probably would have used this https://pkg.go.dev/golang.org/x/net/http/httpproxy#FromEnvironment and only checked the HTTPProxy and HTTPSProxy instead of having 4 nested ifs but it's temporary code so :)
There was a problem hiding this comment.
Code refactored, tell me ;-)
QuentinBisson
approved these changes
Feb 14, 2024
QuantumEnigmaa
approved these changes
Feb 14, 2024
|
Need to be tested on
|
added 2 commits
February 14, 2024 17:10
…eus-meta-operator into update-cnp-with-proxy
QuentinBisson
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards https://github.com/giantswarm/giantswarm/issues/29873
Checklist
I have:
CHANGELOG.md