Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop another bunch of unused metrics #1243

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Drop another bunch of unused metrics #1243

merged 1 commit into from
Mar 30, 2023

Conversation

QuentinBisson
Copy link
Contributor

Let's drop another bunch of unused metrics to reduce prometheus stability issues

Checklist

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@QuentinBisson QuentinBisson self-assigned this Mar 29, 2023
@QuentinBisson QuentinBisson requested a review from a team as a code owner March 29, 2023 15:19
@QuentinBisson QuentinBisson requested review from a team March 29, 2023 15:20
@QuentinBisson QuentinBisson force-pushed the drop-other-unused-metrics branch from d33b29e to b5b84e1 Compare March 29, 2023 15:20
QuantumEnigmaa
QuantumEnigmaa approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the nginx ones will be useful in the future but if they're not currently used let's go on with removing them

@QuentinBisson
Copy link
Contributor Author

@QuantumEnigmaa I'm keeping the one with 1M series that is the only one used :D
image

@QuentinBisson
Copy link
Contributor Author

Hopefully, we can add them back once we have mimir

@Gacko
Copy link
Member

Gacko commented Mar 29, 2023

tbh: I do not remind using them. Maybe some other @giantswarm/team-cabbage does. But yeah, let's drop and re-add when required.

@QuentinBisson QuentinBisson merged commit 449d736 into master Mar 30, 2023
@QuentinBisson QuentinBisson deleted the drop-other-unused-metrics branch March 30, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@QuantumEnigmaa QuantumEnigmaa QuantumEnigmaa approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuentinBisson @Gacko @QuantumEnigmaa