Change SM and PM label selector #18
Conversation
Signed-off-by: QuentinBisson <[email protected]>
|
Tested on gohan |
| podMonitorNamespaceSelector: | ||
| matchLabels: | ||
| name: kube-system | ||
| serviceMonitorNamespaceSelector: {} |
There was a problem hiding this comment.
You removed namespace selector! But I wonder about capi management cluster. The Agent will be able to scrape all SMs
There was a problem hiding this comment.
All SMs and PMs that have defined application.giantswarm.io/team.
Meaning it should exclude customer-defined SMs and PMs.
Clever! I like it!
There was a problem hiding this comment.
Yes the agent will scrape all SMs so we need to change the condition in PMO https://github.com/giantswarm/prometheus-meta-operator/blob/a536ba2de277fa5a6249581d18feee0b31876b36/service/controller/resource/monitoring/prometheus/resource.go#L351
There was a problem hiding this comment.
@hervenicol yes exactly. That way we will pick up managed apps service monitors but not the customer workload :)
There was a problem hiding this comment.
This will also help us enforce that this label is set :)
This PR:
Testing
Tested on a GCP Workload Cluster
Checklist
values.yamlandvalues.schema.jsonare valid.