Use feature gate for S3 storage #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndiDog
force-pushed
the
s3-storage-feature-gate
branch
from
f95969c to
8f61242
Compare
AndiDog
force-pushed
the
s3-storage-feature-gate
branch
from
8f61242 to
2d92ff0
Compare
mnitchev
approved these changes
Jul 2, 2024
fiunchinho
reviewed
Jul 3, 2024
| // yet by the lifecycle policy | ||
| for { | ||
| log.Info("Listing S3 objects of machine pools") | ||
| if feature.Gates.Enabled(feature.MachinePool) { |
There was a problem hiding this comment.
I only found usages of the feature package in the controllers package, or in the main file. It looks like we are introducing a new dependency between this package and the feature package. I'm not sure if this will get accepted upstream, as it seems it goes in a different design direction. I don't know an alternative approach though.
There was a problem hiding this comment.
Since this code runs in the same process, I think it should work functionality-wise. Regarding upstream, that's the risk we take when implementing in the fork first, so we probably need to accept it this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3442
To be merged after #596 (stacked PR).
This adds the suggested changes as requested in the review of #593.