Cancel instance refresh on any relevant change to ASG, delete machine pool user data file from S3 when pruning an old launch template version #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pool user data file from S3 when pruning an old launch template version TODO Add debug logs More debug logs More debug logs Delay directly after cancelling instance refresh Ignore ActiveInstanceRefreshNotFound on cancel (for idempotence), only cancel if unfinished *and* not in Cancelling status Try deleting machine pool user data file from S3 when pruning an old launch template version Add debug logs Read bootstrap data hash from tag since user data != bootstrap data in case of S3 storage Fix error handling Test fixes, remove debug logs Delete machine pool files only if feature flag enabled final tag
fiunchinho
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsumes the improvements from giantswarm/roadmap#3442 and https://github.com/giantswarm/giantswarm/issues/31105, as merged into our CAPA fork with these PRs:
Requires new permission via giantswarm/giantswarm-aws-account-prerequisites#108 (I applied it to all CAPA MCs).
Checklist