Make ServiceMonitor optional (#245)

giantswarm · May 24, 2024 · 29cad8a · 29cad8a
1 parent 159c489
commit 29cad8a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Make ServiceMonitor optional through `serviceMonitor.enabled` helm value (useful in mc-bootstrap).
+
 ## [2.18.0] - 2024-05-02
 
 ### Added

diff --git a/helm/cluster-api-provider-aws/files/copy/service-monitor.yaml b/helm/cluster-api-provider-aws/files/copy/service-monitor.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.serviceMonitor.enabled }}
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
@@ -11,3 +12,4 @@ spec:
   selector:
     matchLabels:
       cluster.x-k8s.io/provider: infrastructure-aws
+{{- end }}
diff --git a/helm/cluster-api-provider-aws/templates/service-monitor.yaml b/helm/cluster-api-provider-aws/templates/service-monitor.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.serviceMonitor.enabled }}
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:
@@ -11,3 +12,4 @@ spec:
   selector:
     matchLabels:
       cluster.x-k8s.io/provider: infrastructure-aws
+{{- end }}
diff --git a/helm/cluster-api-provider-aws/values.schema.json b/helm/cluster-api-provider-aws/values.schema.json
@@ -160,6 +160,15 @@
                 }
             }
         },
+        "serviceMonitor": {
+            "type": "object",
+            "properties": {
+                "enabled": {
+                    "type": "boolean"
+                }
+            },
+            "default": true
+        },
         "verticalPodAutoscaler": {
             "type": "object",
             "properties": {

diff --git a/helm/cluster-api-provider-aws/values.yaml b/helm/cluster-api-provider-aws/values.yaml
@@ -63,6 +63,9 @@ provider:
     accessKeyID: defaultID
     secretAccessKey: defaultKey
 
+serviceMonitor:
+  enabled: true
+
 verticalPodAutoscaler:
   enabled: true