-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update csi driver and other components #32
Conversation
This updates the csi-driver to the latest version, and syncs the versions of the other components with the ones defined in the upstream azurefile-csi chart. The `csi-attacher` component has been removed from the upstream chart, see kubernetes-sigs/azurefile-csi-driver#1664 . Should it be removed from here as well? I couldn't find any info on why it was removed nor if it should be replaced by something else. For now I've bumped the version to the latest release. As per giantswarm/giantswarm#30774
According to this cherrypick:
kubernetes-sigs/azurefile-csi-driver#1468 It seems that this capability is the job of the attacher container.
I don't know enough about the inner workings of CSI drivers to comment further though 😄. However we are not on 1.29 yet. Is there a way to tie a release to Kubernetes version compatibility somehow? EDIT: The table says Kubernetes 1.21+. Maybe we just don't need this thing then. A test will tell |
I'm not familiar with that repo but I would assume that we also need to update the manifests to 1.30.2. |
That's precisely the container that has been removed from the upstream chart 🤔
When they mention that "ControllerPublishVolume capability is removed starting from v1.29.1" they are referring to the Azurefile CSI driver version I think, not the k8s one. In any case, as you mentioned, all CSI versions are compatible starting from k8s 1.21 so we should be good.
Ok so our chart should match the upstream one as much as possible, while keeping our own customisations I assume? I'll see to port all changes then. Maybe someone from @giantswarm/team-phoenix can chime in regarding what to do with the |
This commit syncs all changes made in the upstream chart since the last update.
I've tested this by creating a new cluster and updating the CSI helm release to this dev version. I've created a pod with an azurefile PVC and everything works as expected |
This updates the csi-driver to the latest version, and syncs the versions of the other components with the ones defined in the upstream azurefile-csi chart.
The
csi-attacher
component has been removed from the upstream chart, see kubernetes-sigs/azurefile-csi-driver#1664 .Should it be removed from here as well? I couldn't find any info on why it was removed nor if it should be replaced by something else. For now I've bumped the version to the latest release.I've ported all the relevant upstream changes, including thecsi-attacher
removal.As per https://github.com/giantswarm/giantswarm/issues/30774