Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: remove push-to-docker job and command #492

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Breaking: remove push-to-docker job and command #492

merged 2 commits into from
Jan 16, 2024

Conversation

marians
Copy link
Member

@marians marians commented Jan 16, 2024

Towards giantswarm/roadmap#2882

This PR removes the previously deprecated job push-to-docker, which has been replaced by push-to-registries.

Checklist

@marians marians self-assigned this Jan 16, 2024
@marians marians marked this pull request as ready for review January 16, 2024 08:46
@marians marians requested a review from a team as a code owner January 16, 2024 08:46
@marians marians requested a review from piontec January 16, 2024 08:57
piontec
piontec approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@piontec piontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marians marians merged commit 5194390 into main Jan 16, 2024
5 checks passed
@marians marians deleted the breaking-remove-push-to-docker branch January 16, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piontec piontec piontec approved these changes

@mproffitt mproffitt mproffitt approved these changes

Assignees

@marians marians

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marians @piontec @mproffitt