Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump app-operator to v3.0.0 and use shorter resync period #81

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jan 5, 2021

Towards https://github.com/giantswarm/giantswarm/issues/14666

Checklist

  • Update changelog in CHANGELOG.md.

@rossf7 rossf7 self-assigned this Jan 5, 2021
@@ -11,7 +11,10 @@ env:
ALLOW_OVERWRITE: true
DISABLE_API: false`

operatorValuesYAML string = `Installation:
operatorValuesYAML string = `operatorkit:
resyncPeriod: "20s"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finalizer TTL in operatorkit is 3 * resync period. So its now 1 minute instead of 15 mins.

Each test run with app-build-suite takes at least 1 minute so this TTL should be short enough.

@rossf7 rossf7 marked this pull request as ready for review January 5, 2021 17:05
@rossf7 rossf7 requested a review from a team January 5, 2021 17:05
Copy link
Contributor Author

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossf7
Copy link
Contributor Author

rossf7 commented Jan 7, 2021

Going with a ping.

@rossf7 rossf7 merged commit 550b795 into master Jan 7, 2021
@rossf7 rossf7 deleted the app-op-v3 branch January 7, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant