Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align files #61

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Align files #61

merged 2 commits into from
Dec 4, 2020

Conversation

architectbot
Copy link
Contributor

@architectbot architectbot requested a review from a team December 2, 2020 14:47
rossf7
rossf7 reviewed Dec 2, 2020
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piontec The automation is trying to remove your fix. 🤦‍♂️

Do you know if there is a solution for that? Otherwise I can ask in #wg-dev-automation

@piontec
Copy link
Contributor

piontec commented Dec 3, 2020

@piontec The automation is trying to remove your fix.

Do you know if there is a solution for that? Otherwise I can ask in #wg-dev-automation

No idea. I know Simon was asking them to make it more configurable, so you could choose which parts to generate and which to skip. But better just probably ask.

rossf7
rossf7 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in the version command that was kindly fixed by @kopiczko in #63

With that fix we don't need to change the Makefile.

@rossf7 rossf7 merged commit e942198 into master Dec 4, 2020
@rossf7 rossf7 deleted the teams-alignment-branch branch December 4, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossf7 rossf7 rossf7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@architectbot @piontec @rossf7 @actions-user