Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app-operator and chart-operator for K8s 1.20 support #118

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Update app-operator and chart-operator for K8s 1.20 support #118

merged 1 commit into from
Apr 6, 2021

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Apr 6, 2021 •
edited
Loading

Fixes #111

Removes usage of self link so we don't need feature flags with kind.

Checklist

  • Update changelog in CHANGELOG.md.

@rossf7 rossf7 self-assigned this Apr 6, 2021
@rossf7 rossf7 marked this pull request as ready for review April 6, 2021 13:26
@rossf7 rossf7 requested review from a team April 6, 2021 13:26
ubergesundheit
ubergesundheit approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but LGTM!

@rossf7
Copy link
Contributor Author

rossf7 commented Apr 6, 2021

Thanks @ubergesundheit! I tested with the app-exporter test and it worked fine. Going with this.

@rossf7 rossf7 merged commit 9929316 into master Apr 6, 2021
@rossf7 rossf7 deleted the k8s-1-20 branch April 6, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubergesundheit ubergesundheit ubergesundheit approved these changes

Assignees

@rossf7 rossf7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apptestctl fails on Kubernetes 1.20
2 participants
@rossf7 @ubergesundheit