Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log go test outputs #126

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Log go test outputs #126

merged 5 commits into from
Jun 16, 2022

Conversation

uvegla
Copy link
Contributor

@uvegla uvegla commented Jun 16, 2022

We capture the output and it is not displayed on the CI logs so we do not know why it failed when it does, for example.

@uvegla uvegla force-pushed the log-go-test-outputs branch from 3da0769 to ff7be54 Compare June 16, 2022 10:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #126 (ba62312) into master (12f28c6) will increase coverage by 0.01%.
The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   62.37%   62.39%   +0.01%     
==========================================
  Files          16       16              
  Lines         925      936      +11     
  Branches      113      115       +2     
==========================================
+ Hits          577      584       +7     
- Misses        319      321       +2     
- Partials       29       31       +2     
Impacted Files Coverage Δ
app_test_suite/steps/executors/gotest.py 65.51% <63.63%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f28c6...ba62312. Read the comment docs.

@uvegla uvegla force-pushed the log-go-test-outputs branch from 34512c0 to ba62312 Compare June 16, 2022 12:48
@uvegla uvegla requested a review from QuentinBisson June 16, 2022 13:04
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uvegla uvegla merged commit bba67ff into master Jun 16, 2022
@uvegla uvegla deleted the log-go-test-outputs branch June 16, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants