Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent chart CR creation if managed cm and secret are not ready #598

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Prevent chart CR creation if managed cm and secret are not ready #598

merged 3 commits into from
Dec 2, 2020

Conversation

corest
Copy link
Contributor

@corest corest commented Dec 2, 2020

Towards https://github.com/giantswarm/giantswarm/issues/14604

Checklist

  • Update changelog in CHANGELOG.md.

@corest corest requested a review from a team December 2, 2020 14:43
@corest corest mentioned this pull request Dec 2, 2020
Closed
1 task
@corest corest requested a review from a team December 2, 2020 14:43
rossf7
rossf7 approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corest corest merged commit c0cfb9a into master Dec 2, 2020
@corest corest deleted the update-app-library-validator branch December 2, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossf7 rossf7 rossf7 approved these changes

@kopiczko kopiczko kopiczko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corest @rossf7 @kopiczko