Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

change ConfigMajorVersion annotation #633

Merged
merged 3 commits into from
Dec 2, 2020
Merged

change ConfigMajorVersion annotation #633

merged 3 commits into from
Dec 2, 2020

Conversation

kubasobon
Copy link
Contributor

@kubasobon kubasobon commented Dec 2, 2020 •
edited
Loading

Checklist

  • Consider SIG UX feedback.
  • Update changelog in CHANGELOG.md.
  • If adding a new type, ensure that it is added to the CRD unit tests.

@kubasobon kubasobon self-assigned this Dec 2, 2020
@kubasobon kubasobon requested a review from a team December 2, 2020 12:03
@kubasobon kubasobon merged commit a6f5540 into master Dec 2, 2020
@kubasobon kubasobon deleted the config-version branch December 2, 2020 12:25
kopiczko
kopiczko reviewed Dec 2, 2020
View reviewed changes
CHANGELOG.md
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Change `config.giantswarm.io/major-version` annotation to `config.giantswarm.io/version`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change in the release PR to:

- Change (unused yet) `config.giantswarm.io/major-version` annotation to `config.giantswarm.io/version`.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kopiczko kopiczko kopiczko left review comments

@corest corest corest approved these changes

Assignees

@kubasobon kubasobon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubasobon @corest @kopiczko