(Windows) net_io_counters() overflow issue

[EvinceMoi]

not tested cause' I don't have vs2010

Signed-off-by: baneyue [email protected]

[giampaolo]

Which issue are you trying to address here and why do we need this? Is this about #501?

[EvinceMoi]

sorry, I should ticket an issue first.

It' about the net_io_counter value overflow problem, since the original code use 32bit Windows API(use DWORD for in/out octets, it's easily overflowed in use for me, so i just change it to 64bit version

[giampaolo]

Ah OK, so the problem here is that net_io_counter() may overflow. Question: does this work on 32 bit versions as well?

[EvinceMoi]

sorry for late reply, as the MSDN does not note the api should be used on 32 or 64 bit Windows, so I guess it should work for 32bit ;-)

One thing for sure is that the api will support Windows Vista and above.

[giampaolo]

We still support Windows XP though. Does the doc mentions that this is Vista+ only?

[EvinceMoi]

Yes, Vista+ only for sure.

[giampaolo]

Well, in this case we need the necessary workaround to support this in Windows XP as well.

[giampaolo]

Sorry for the big delay. Can you please update this PR (it is no longer mergeable)?

[giampaolo]

I would like to push this forward but I want to make sure it won't break Windows XP first. Can somebody please check (my virtualized XP box no longer works)?

[giampaolo]

This was fixed in #835 maintaining backward compatibility with Windows XP. Closing this out.