Implicitly include <sys/param.h> so that __FreeBSD_version checks wor… #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Could you please also update HISTORY and CREDITS files? |
…ut including <sys/param.h>
Done & updated PR 2114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly include <sys/param.h> so that __FreeBSD_version checks work properly
Summary
Description
Implicitly include <sys/param.h> on all code files in psutil/arc/freebsd that make use of __FreeBSD_version.
While some code already includes it directly and others pull it in indirectly via other includes, mem.c was not and made __FreeBSD_version checks silently fail on some common FreeBSD installations, including default setups with FreeBSD on arm platforms.