#557 (NetBSD): implement process cwd()

psutil/_psbsd.py

@@ -526,8 +526,21 @@ def cwd(self):
             # sometimes we get an empty string, in which case we turn
             # it into None
             if OPENBSD and self.pid == 0:
-                return None  # ...else raises EINVAL
-            return cext.proc_cwd(self.pid) or None
+                return None  # ...else it would raise EINVAL
+            elif NETBSD:
+                try:
+                    return os.readlink("/proc/%s/cwd" % self.pid)
+                except OSError as err:
+                    if err.errno == errno.ENOENT:
+                        if not pid_exists(self.pid):
+                            raise NoSuchProcess(self.pid, self._name)
+                        else:
+                            raise ZombieProcess(
+                                self.pid, self._name, self._ppid)
+                    else:
+                        raise
+            else:
+                return cext.proc_cwd(self.pid) or None
 
         @wrap_exceptions
         def memory_maps(self):

psutil/_psutil_bsd.c

@@ -936,8 +936,10 @@ PsutilMethods[] = {
      "Return process IO counters"},
     {"proc_tty_nr", psutil_proc_tty_nr, METH_VARARGS,
      "Return process tty (terminal) number"},
+#ifdef __FreeBSD__ || __OpenBSD__
     {"proc_cwd", psutil_proc_cwd, METH_VARARGS,
      "Return process current working directory."},
+#endif
 #if defined(__FreeBSD_version) && __FreeBSD_version >= 800000 || __OpenBSD__ || defined(__NetBSD__)
     {"proc_num_fds", psutil_proc_num_fds, METH_VARARGS,
      "Return the number of file descriptors opened by this process"},

psutil/arch/bsd/netbsd.c

@@ -513,13 +513,6 @@ psutil_proc_num_fds(PyObject *self, PyObject *args) {
 }
 
 
-PyObject *
-psutil_proc_cwd(PyObject *self, PyObject *args) {
-    // Not implemented
-    return NULL;
-}
-
-
 // see sys/kern/kern_sysctl.c lines 1100 and
 // usr.bin/fstat/fstat.c print_inet_details()
 static char *

psutil/arch/bsd/netbsd.h

@@ -22,7 +22,6 @@ PyObject *psutil_proc_threads(PyObject *self, PyObject *args);
 PyObject *psutil_virtual_mem(PyObject *self, PyObject *args);
 PyObject *psutil_swap_mem(PyObject *self, PyObject *args);
 PyObject *psutil_proc_num_fds(PyObject *self, PyObject *args);
-PyObject *psutil_proc_cwd(PyObject *self, PyObject *args);
 PyObject *psutil_proc_connections(PyObject *self, PyObject *args);
 PyObject *psutil_per_cpu_times(PyObject *self, PyObject *args);
 PyObject* psutil_disk_io_counters(PyObject* self, PyObject* args);

test/_posix.py

@@ -262,6 +262,12 @@ def call(p, attr):
         if failures:
             self.fail('\n' + '\n'.join(failures))
 
+    @unittest.skipUnless(os.path.islink("/proc/%s/cwd" % os.getpid()),
+                         "/proc fs not available")
+    def test_cwd_proc(self):
+        self.assertEqual(os.readlink("/proc/%s/cwd" % os.getpid()),
+                         psutil.Process().cwd())
+
 
 def main():
     test_suite = unittest.TestSuite()