fix #1875: username return ERROR_NONE_MAPPED

HISTORY.rst

@@ -19,7 +19,9 @@ XXXX-XX-XX
 
 - 1866_: [Windows] process exe(), cmdline(), environ() may raise "invalid
   access to memory location" on Python 3.9.
-- 1874_: [Solaris] wrong swap output given when encrypted column is present
+- 1874_: [Solaris] wrong swap output given when encrypted column is present.
+- 1875_: [Windows] process username() may raise ERROR_NONE_MAPPED if the SID
+  has no corresponding account name. In this case AccessDenied is now raised.
 - 1877_: [Windows] OpenProcess may fail with ERROR_SUCCESS. Turn it into
   AccessDenied or NoSuchProcess depending on whether the PID is alive.
 - 1886_: [macOS] EIO error may be raised on cmdline() and environment(). Now

psutil/_psutil_windows.c

@@ -895,6 +895,19 @@ psutil_proc_username(PyObject *self, PyObject *args) {
                 free(domainName);
                 continue;
             }
+            else if (GetLastError() == ERROR_NONE_MAPPED) {
+                // From MS doc:
+                // https://docs.microsoft.com/en-us/windows/win32/api/winbase/
+                //     nf-winbase-lookupaccountsida
+                // If the function cannot find an account name for the SID,
+                // GetLastError returns ERROR_NONE_MAPPED. This can occur if
+                // a network time-out prevents the function from finding the
+                // name. It also occurs for SIDs that have no corresponding
+                // account name, such as a logon SID that identifies a logon
+                // session.
+                AccessDenied("LookupAccountSidW -> ERROR_NONE_MAPPED");
+                goto error;
+            }
             else {
                 PyErr_SetFromOSErrnoWithSyscall("LookupAccountSidW");
                 goto error;