Better error handling for empty certificate/keystore files #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csstaub
requested review from
mcpherrinm,
alokmenghrajani,
stfinney,
wtmcc and
jbpeirce
|
Bumping this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug found by @wtmcc wherein ghostunnel will fail with a nil pointer exception when the certificate/keystore file being read is empty, specifically because certigo will read the file successfully but due to not finding any certificates the resulting certAndKey.Leaf will be nil. Also bumps certigo dependency to pick up a change to make the error message from the read call better.