fix: allow resources surrogates #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs https://github.com/gorhill/uBlock/wiki/Resources-Library refs ghostery#4392 fixes ghostery#4393 test: allow scriptlets being used as resources fix: allow redirect resources surrogates test: drop outdated tests fix: always query with file extension chore: strictly check content type test: resources surrogate test: drop outdated
seia-soto
force-pushed
the
allow-scriptlet-resources
branch
from
7c60ded to
0119d6a
Compare
seia-soto
changed the title
chrmod
requested changes
Oct 29, 2024
| @@ -272,6 +280,12 @@ describe('#Resources', function () { | |||
| it('includes setup for scritplet globals', function () { | |||
| expect(resources.getScriptlet('a')).to.include('var scriptletGlobals = {};'); | |||
| }); | |||
|
|
|||
| it('allows resources surrogate', function () { | |||
| expect(resources.getScriptlet('surrogate')) | |||
There was a problem hiding this comment.
are those things always called without .js ?
There was a problem hiding this comment.
Yes, resources surrogates are always called without suffix or file extension. Also, uBo gradually plan to drop calling scriptlets with suffix or file extension in the future.
chrmod
reviewed
Oct 30, 2024
Co-authored-by: Krzysztof Modras <[email protected]>
chrmod
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/gorhill/uBlock/wiki/Resources-Library
refs #4392
fixes #4393