-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: exception of script injection not respecting aliases #4376
Merged
chrmod
merged 11 commits into
ghostery:master
from
seia-soto:respect-aliases-in-scriptlet-exception
Oct 25, 2024
Merged
fix: exception of script injection not respecting aliases #4376
chrmod
merged 11 commits into
ghostery:master
from
seia-soto:respect-aliases-in-scriptlet-exception
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop unused methods - simplify scriptlet name parsing
chrmod
reviewed
Oct 18, 2024
Co-authored-by: chrmod <[email protected]>
Co-authored-by: chrmod <[email protected]>
Co-authored-by: chrmod <[email protected]>
Co-authored-by: chrmod <[email protected]>
Co-authored-by: chrmod <[email protected]>
chrmod
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4058
This PR adds:
public resolveScriptlet
to exposeprivate scriptletsByName
and the scriptlet objects (we need another method sincepublic getScriptlet
returns fully compiled scriptlet) in resourcespublic getScriptletSelector(resolver: (name: string) => string | undefined): string
to normalise the selectors of script inject cosmetic filters in cosmetic filtersThe approach comes with not to add dependency to
CosmeticFilter
and not to halt existing properties ofResources
(including private ones).