Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services): make everything extendable by using protected #411

Merged
merged 2 commits into from
Jul 15, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jul 15, 2021

  • it was mentioned by a user of Angular-Slickgrid that it would be nice to extend some of the Services and so I decided to make them all extendable by using protected instead of private

@ghiscoding ghiscoding requested a review from AnnetteZhang July 15, 2021 14:14
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #411 (a4588ea) into master (502cc0e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          219       219           
  Lines        13329     13329           
  Branches      4555      4555           
=========================================
  Hits         13329     13329           
Impacted Files Coverage Δ
packages/common/src/services/gridEvent.service.ts 100.00% <ø> (ø)
packages/binding/src/binding.service.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filterFactory.ts 100.00% <100.00%> (ø)
...ages/common/src/services/backendUtility.service.ts 100.00% <100.00%> (ø)
...ckages/common/src/services/bindingEvent.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/collection.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
.../common/src/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502cc0e...a4588ea. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit 2abe803 into master Jul 15, 2021
@AnnetteZhang AnnetteZhang deleted the feat/make-backend-services-extendable branch July 15, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants