-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tree): improve Tree Data speed considerably, fixes #307 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 213 212 -1
Lines 13063 13110 +47
Branches 4279 4297 +18
=========================================
+ Hits 13063 13110 +47
Continue to review full report at Codecov.
|
- most framework requires one cycle for the binding to be executed and because of that the spinner was showing too late, we can fix this by having the pubsub publish method to return a promise with setTimeout of 0 (which is 1 cycle) and now the spinner works as intended for all events recently added
- this basically runs a Formatter into the Tree Formatter - also remove `indentedChildValuePrefix` that can easily be done in this new titleFormatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs
initialSort
propertyonBeforeSortChange
,onBeforeFilterChange
,onBeforeCollapse
, ...) to help display spinner when dealingclearFilters
remove possibly unnecessarydataView.refresh()
, need to test a bit more with backend service as well