Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): few issues found with Tree Data, fixes #307 #326

Merged
merged 10 commits into from
May 5, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 30, 2021

  1. initial sort not always working
  2. tree level property should not be required while providing a parentId relation
  3. tree data was loading and rendering the grid more than once (at least 1x time before the sort and another time after the tree was built) while it should only be rendered once

TODOs

  • should work with all 3 things mentioned
  • add missing unit tests
  • need to investigate, it seems to remove the tree level property when original dataset doesn't have the property (e,g, indent)
  • do more tests in our SF implementation
  • add throw error to not use multi-column sorting with Tree Data
  • should also work when adding new item dynamically as shown in the demo
    • there was an issue in the demo because the demo also has a filter preset
  • use gridService.addItem(x) (and addItems()) and make sure that it refreshes & resort the hierarchical dataset by itself (user shouldn't have to do anything except calling this service addItem)
  • it should also work with updateFilters and updateSingleFilter
  • add throw error when using backend service api with Tree Data since it isn't supported
  • export to file/excel should also export the tree and its indentation

1. initial sort not always working
2. tree level property should not be required while providing a parentId relation
3. tree data was loading and rendering the grid more than once (at least 1x time before the sort and another time after the tree was built) while it should only be rendered once
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #326 (8c4c2b8) into master (1110b0d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #326   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       213    +1     
  Lines        12894     12979   +85     
  Branches      4413      4446   +33     
=========================================
+ Hits         12894     12979   +85     
Impacted Files Coverage Δ
packages/common/src/formatters/formatters.index.ts 100.00% <100.00%> (ø)
packages/common/src/formatters/index.ts 100.00% <100.00%> (ø)
...kages/common/src/formatters/treeExportFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/formatters/treeFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/treeData.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/utilities.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1110b0d...8c4c2b8. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(tree): couple of issues found in Tree Data, fixes #307 WIP - fix(tree): couple of issues found in Tree Data, fixes #307 Apr 30, 2021
@ghiscoding ghiscoding changed the title WIP - fix(tree): couple of issues found in Tree Data, fixes #307 fix(tree): couple of issues found in Tree Data, fixes #307 Apr 30, 2021
@ghiscoding ghiscoding changed the title fix(tree): couple of issues found in Tree Data, fixes #307 WIP - fix(tree): few issues found with Tree Data, fixes #307 May 4, 2021
@ghiscoding ghiscoding changed the title WIP - fix(tree): few issues found with Tree Data, fixes #307 fix(tree): few issues found with Tree Data, fixes #307 May 4, 2021
@ghiscoding ghiscoding merged commit 3d6e51c into master May 5, 2021
@ghiscoding ghiscoding deleted the bugfix/tree-data-initial-sort branch May 5, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree Sort on first page load is incorrect
1 participant