-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree): few issues found with Tree Data, fixes #307 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. initial sort not always working 2. tree level property should not be required while providing a parentId relation 3. tree data was loading and rendering the grid more than once (at least 1x time before the sort and another time after the tree was built) while it should only be rendered once
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 213 +1
Lines 12894 12979 +85
Branches 4413 4446 +33
=========================================
+ Hits 12894 12979 +85
Continue to review full report at Codecov.
|
Merged
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parentId
relationTODOs
indent
)gridService.addItem(x)
(andaddItems()
) and make sure that it refreshes & resort the hierarchical dataset by itself (user shouldn't have to do anything except calling this service addItem)updateFilters
andupdateSingleFilter