Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose all Extensions in new getter prop & fix draggable #29

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

ghiscoding
Copy link
Owner

  • also renamed the SharedService.grid to SharedService.slickGrid to align with the vanilla bundle slickGrid property
  • also fixed the Draggable Grouping example that was not working, apparently the option enableColumnReorder can be a callback function as well as a boolean

ghiscoding-SE and others added 2 commits July 27, 2020 20:08
- also renamed the SharedService.grid to SharedService.slickGrid to align with the vanilla bundle `slickGrid` property
- also fixed the Draggable Grouping example that was not working, apparently the option `enableColumnReorder` can be a callback function as well as a boolean
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #29 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   99.60%   99.60%   +0.01%     
==========================================
  Files         185      185              
  Lines       10008    10017       +9     
  Branches     3401     3402       +1     
==========================================
+ Hits         9967     9976       +9     
  Misses         41       41              
Impacted Files Coverage Δ
...ages/common/src/enums/gridAutosizeColsMode.enum.ts 100.00% <ø> (ø)
packages/common/src/enums/gridStateType.enum.ts 100.00% <ø> (ø)
packages/common/src/enums/index.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/autoTooltipExtension.ts 100.00% <100.00%> (ø)
...src/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/cellMenuExtension.ts 100.00% <100.00%> (ø)
...common/src/extensions/checkboxSelectorExtension.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
...ommon/src/extensions/draggableGroupingExtension.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dc2e6f...c6e8b21. Read the comment docs.

@ghiscoding ghiscoding merged commit 07257b2 into master Jul 28, 2020
@ghiscoding ghiscoding deleted the feat/expose-addons branch July 28, 2020 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants