gridstate sortcolumns field instead id property of column

[zewa666]

Describe the bug

hey there,

when using the OData Service in combo with gridstate events to persist the user selection to e.g localstorage I do get errors when restoring cols on next refresh.

the root cause was brought down to the columnId containing the field property instead of the id as seen here

slickgrid-universal/packages/odata/src/services/grid-odata.service.ts

Line 548 in 38b465c

columnId: columnFieldName,

I didnt dig deeper but guess there were reasons for doing so in order to make sorting work. do you know why or should I dig deeper?

Reproduction

• activate odata service
• add gridstate change listener
• store to localstorage
• apply to preset when refreshing

Which Framework are you using?

Angular

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| (framework used)    | VERSION |
| Slickgrid-Universal | latest |
| TypeScript          | VERSION |
| Browser(s)          | VERSION |
| System OS           | VERSION |

Validations

• Follow our Code of Conduct
• Read the Wikis.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[ghiscoding]

hmm I'm not really sure about this one, I actually haven't used the OData Service in a very long time, @jr01 might have more knowledge since I know he's a big user (and contributor to the OData Service). @jr01 are you using the OData with Grid State/Presets?

[zewa666]

looking at the graphql implementation, where its done correctly

slickgrid-universal/packages/graphql/src/services/graphql.service.ts

Line 587 in 38b465c

currentSorters.push({

, this perhaps was simply a mistake

[ghiscoding]

oh ok yeah that must be a typo error, I'd be ok to change it since yes it's supposed to be the column id as the name suggest (which is often, but not always, identical to the column name). By the way, I had to click on the link you provided and open it to see the differences, I'm not sure if you knew or not but you should select multiple lines then click on Copy Permalink to be able to see a few lines in here (note that this only works with code that is in the same repo, for example that wouldn't work pasting Angular-Slickgrid permalink in here)

and that gives me the following, the other good thing is that it's also assigned to a commit, so if the code changes in the future, the link will always point to the code that the permalink was created with :)

slickgrid-universal/packages/graphql/src/services/graphql.service.ts

Lines 587 to 590 in 38b465c

	currentSorters.push({
	columnId: column.sortCol.id + '',
	direction: column.sortAsc ? SortDirection.ASC : SortDirection.DESC
	});

[zewa666]

ok I'll create a PR for that. good opportunity to read up on the OData implementation

[jr01]

We currently only store the columns (not sorters and not filters) from the grid state in our backend, so we won't be affected by the fix :)